feat: support multi_az_with_standby_enabled for opensearch
#196
Conversation
| dedicated_master_enabled = var.dedicated_master_enabled | ||
| dedicated_master_count = var.dedicated_master_count | ||
| dedicated_master_type = var.dedicated_master_type | ||
| multi_az_with_standby_enabled = var.multi_az_with_standby_enabled |
There was a problem hiding this comment.
What version of the AWS provider was multi_az_with_standby_enabled added in? Does our current pin of the AWS provider in versions.tf require that version or above? Please look into this, update if needed, and then rerun the README generation with make init && make readme. Thanks!
There was a problem hiding this comment.
Thanks for the callout! It does need a minimum bump, the variable was introduced in https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5150-august-31-2023. I've updated that value and run README generation. Note that that make readme fixes some things I missed when I did it manually, but also introduces some minor, seemingly unrelated changes (e.g., extra /).
lukehsiao
force-pushed
the
main
branch
3 times, most recently
from
0232f59 to
a0c05dd
Compare
Gowiem
added
enhancement
|
/terratest |
|
I see some test failures, but looking at the logs, they don't look directly related to my change. If I'm responsible for getting these to passing, could anyone provide some guidance? |
Note that this bumps the minimum `hashicorp/aws` provider version to 5.15.0, where this parameter was introduced [[1]]. The README diff was generated with `make init` and `make readme`, and introduces some minor unrelated changes. [1]: https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5150-august-31-2023 Closes: cloudposse#195
|
/terratest |
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
|
@lukehsiao the tests for this child module need some action from the @cloudposse team as there is an issue with the tests failing to find some R53 records in their AWS account. I'll bring this up internally to the contributors group and we'll work to get someone on it shortly. Thanks for the patience! |
feat: support
multi_az_with_standby_enabledfor opensearchNote that this bumps the minimum
hashicorp/awsprovider version to5.15.0, where this parameter was introduced [1].
The README diff was generated with
make initandmake readme, andintroduces some minor unrelated changes.
Closes: #195
what
This PR simply exposes a new variable (
multi_az_with_standby_enabled) for OpenSearch clusters.why
This is the recommended setting by AWS, so it makes sense to be able to do this via terraform.
references
Closes: #195