Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added variable lambda_source_path to support custom lambda #46

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Added variable lambda_source_path to support custom lambda #46

merged 2 commits into from
Jan 31, 2024

Conversation

vladsmrt
Copy link
Contributor

what

why

references

@vladsmrt vladsmrt requested review from a team as code owners January 28, 2024 08:03
@joe-niland joe-niland added the patch A minor, backward compatible change label Jan 28, 2024
@joe-niland joe-niland self-requested a review January 28, 2024 08:40
@joe-niland
Copy link
Member

Hi @vladsmrt thanks for your contribution.

Could you please briefly fill out the PR template, and also run the following and commit?

make init
make github/init
make readme

You may also need to install gomplate: https://docs.gomplate.ca/installing/

@dudymas
Copy link
Contributor

dudymas commented Jan 30, 2024

/terratest

@Benbentwo
Copy link
Member

This is a pass through for https://github.com/terraform-aws-modules/terraform-aws-notify-slack/blob/master/variables.tf#L43-L47

@Benbentwo Benbentwo merged commit b0a5f78 into cloudposse:main Jan 31, 2024
10 checks passed
@vladsmrt vladsmrt deleted the custom_lambda branch February 3, 2024 10:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladsmrt @joe-niland @dudymas @Benbentwo