Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding EnabledMfas to cognito UserPool Object. #1507

Merged
merged 2 commits into from
Oct 13, 2019

Conversation

castaway2000
Copy link
Contributor

related to this #1506

@markpeek markpeek merged commit 79a7086 into cloudtools:master Oct 13, 2019
@markpeek
Copy link
Member

Thanks!

@markpeek
Copy link
Member

@castaway2000 I looked at #1508 and the new resources available. I was going to add them via my generator script. However, when looking at EnabledMfas, I missed that it is a list of strings. Can you confirm your usage of it and then I can correct with my other commit.

@castaway2000
Copy link
Contributor Author

@markpeek my implementation is direct from the CFT docs where it is a list of strings.

Userpool doc:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cognito-userpool.html

direct doc:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cognito-userpool.html#cfn-cognito-userpool-enabledmfas

i am building with the latest revision of troposphere but edited and ran the CFT confirming the current implementation to be working. then copied the code over directly for this PR.

let me know if you need any additional info.

@markpeek
Copy link
Member

OK, then instead of this 'EnabledMfas': (basestring, False), it should be implemented 'EnabledMfas': ([basestring], False),. Note the brackets that imply a list of strings.

@castaway2000
Copy link
Contributor Author

@markpeek as soon as I realized it i made a PR for it. #1511

davemasino pushed a commit to davemasino/troposphere that referenced this pull request Oct 17, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants