Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add CloudWatch Alarm TreatMissingData validator #1536

Conversation

marinpurgar
Copy link
Contributor

@marinpurgar marinpurgar commented Dec 11, 2019

Add the CloudWatch Alarm ThreatMissindData Property validator.
Add the Unit Test for validate_threat_missing_data.
Add Unit Test for validate_units.

Merge with upstream master
- add validate_treat_missing_data validator
- add test_treat_missing_data test
- add test_unit test
@marinpurgar marinpurgar changed the title Add CloudWatch Alarm TreatMissingData validator [WIP] Add CloudWatch Alarm TreatMissingData validator Dec 11, 2019
@marinpurgar marinpurgar changed the title [WIP] Add CloudWatch Alarm TreatMissingData validator Add CloudWatch Alarm TreatMissingData validator Dec 11, 2019
Copy link
Member

@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I added a comment about the return indentation and testing.

@marinpurgar marinpurgar requested a review from markpeek December 29, 2019 11:32
@markpeek markpeek merged commit d902ec6 into cloudtools:master Jan 7, 2020
@markpeek
Copy link
Member

markpeek commented Jan 7, 2020

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants