Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Serverless::Application and Serverless ApplicationLocation #1549

Merged
merged 2 commits into from
Jun 13, 2020

Conversation

dovy
Copy link
Contributor

@dovy dovy commented Dec 31, 2019

I found these were missing, so I implemented them. I hope they find their way into the core so I can stop using a shim. ;)

@dovy
Copy link
Contributor Author

dovy commented Jan 2, 2020

sigh Not sure what you want to do here. Actually this is SAM macros being thrown into CloudFormation and they have no docs to show how to do it the vanilla CloudFormation way.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-secretsmanager-rotationschedule.html

But unless you append the transform structure https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/transform-section-structure.html to your template, it will fail. Gah.

@markpeek markpeek merged commit ba7dba0 into cloudtools:master Jun 13, 2020
@markpeek
Copy link
Member

Thanks! Sorry for the delay. Also, I'll be fixing up a couple of things like added blank lines and removing the validate.

@PatMyron PatMyron linked an issue Jan 2, 2022 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Serverless Application Model (SAM) support
2 participants