New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add missing SecretTargetAttachment TargetTypes #1578

Merged

markpeek merged 1 commit into cloudtools:master from codingtim:feature/secrettargetattachment-other-targettypes

Feb 4, 2020

Contributor

codingtim commented Feb 4, 2020 •

edited

Loading

CloudFormation supports more TargetTypes than currently present in the
VALID_TARGET_TYPES. This pull request adds the missing values.
List of valid TargetTypes is found at:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-secretsmanager-secrettargetattachment.html#cfn-secretsmanager-secrettargetattachment-targettype


          Add missing SecretTargetAttachment TargetTypes

b1af460

Cloudformation supports more TargetTypes than currently present in the
VALID_TARGET_TYPES. This pull request adds the missing values.
List of valid TargetTypes is found at:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-secretsmanager-secrettargetattachment.html#cfn-secretsmanager-secrettargetattachment-targettype

RobKenis approved these changes

View reviewed changes

markpeek merged commit 2f85f3b into cloudtools:master

Member

markpeek commented Feb 4, 2020

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet