Add SourcePrefixListId to SecurityGroupRule

[James-TR]

Add SourcePrefixListId to combined SecurityGroupRule for consistency
with SecurityGroupIngress and SecurityGroupEgress

[PatMyron]

Where is this SecurityGroupRule class used?

[James-TR]

I'm using it to inline security group rules into the SecurityGroupIngress and SecurityGroupEgress properties of a SecurityGroup by creating a list of SecurityGroupRule classes. This saves creating an ingress in the resultant CF template per-rule and allows everything to be nicely inlined.

In my case I have a number of locations which need the same set of ports alowed into an ingress rule on the security group, so I just throw these into an list and call a loop over it to populate my ingresses.

locations = [
    {'Network': 'pl-1234567890123456a', 'Location': 'VPN'},
    {'Network': 'pl-1234567890123456b', 'Location': 'Offices'}
]

sg_ingress = []
for config in locations:
    sg_ingress.append(
        SecurityGroupRule(
            SourcePrefixListId=config['Network'],
            Description=f"{config['Location']} - SSH",
            FromPort="22",
            ToPort="22",
            IpProtocol="tcp"
        )
    )
    sg_ingress.append(
        SecurityGroupRule(
            SourcePrefixListId=config['Network'],
            Description=f"{config['Location']} - RDP",
            FromPort="3389",
            ToPort="3389",
            IpProtocol="tcp"
        )
    )
    sg_ingress.append(
        SecurityGroupRule(
            SourcePrefixListId=config['Network'],
            Description=f"{config['Location']} - WinRM",
            FromPort="5986",
            ToPort="5986",
            IpProtocol="tcp"
        )
    )

t.add_resource(SecurityGroup(
    'AccessSg',
    SecurityGroupIngress=sg_ingress,
    VpcId=Ref("VPCId"),
    GroupDescription="Access Security Group",
    Tags=Tags(
        Name="Access SG"
    )
))

[PatMyron]

Got it, used for these lists:

troposphere/troposphere/ec2.py

Lines 597 to 598 in 3fff834

	'SecurityGroupEgress': (list, False),
	'SecurityGroupIngress': (list, False),

AWS::EC2::SecurityGroup.Ingress.SourcePrefixListId