Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issues with ecs.EFSVolumeConfiguration usage #1808

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Fix issues with ecs.EFSVolumeConfiguration usage #1808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c25785c
Add required flag for AuthorizationConfig property
avosper-intellaegis Oct 13, 2020
3f72e57
Update ValueError value
avosper-intellaegis Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion troposphere/ecs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ class AuthorizationConfig(AWSProperty):

class EFSVolumeConfiguration(AWSProperty):
props = {
'AuthorizationConfig': AuthorizationConfig,
'AuthorizationConfig': (AuthorizationConfig, False),
'FilesystemId': (basestring, True),
'RootDirectory': (basestring, False),
'TransitEncryption': (ecs_efs_encryption_status, False),
Expand Down
3 changes: 2 additions & 1 deletion troposphere/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,7 @@ def ecs_efs_encryption_status(status):
valid_status = ['ENABLED', 'DISABLED']
if status not in valid_status:
raise ValueError(
'ECS EFS Encryption in transit can only be one of' % (
'ECS EFS Encryption in transit can only be one of: "%s"' % (
', '.join(valid_status))
)
return status