Add UpdateConfig to NodeGroup #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markpeek
reviewed
Dec 15, 2021
troposphere/eks.py
Outdated
| @@ -188,6 +193,7 @@ class Nodegroup(AWSObject): | |||
| "ReleaseVersion": (str, False), | |||
| "RemoteAccess": (RemoteAccess, False), | |||
| "ScalingConfig": (ScalingConfig, False), | |||
| "UpdateConfig": (UpdateConfig, False), | |||
There was a problem hiding this comment.
Quick change for this PR, can you alphabetize this new property? Thanks!
There was a problem hiding this comment.
can you kindly run workflows once more? thanks! @markpeek
There was a problem hiding this comment.
Try this if you have the black formatter installed:
black troposphere/eks.py
There was a problem hiding this comment.
indentation issues fixed, thanks.
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
UpdateConfigto NodeGroup, see