adding support for autoscaling notification configurations #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice - I'm going to go ahead and merge this, but then I'm going to update the class to use the AWSProperty class as a parent so we can ditch the init boilerplate. We still need to do this on a lot of classes in this library. Thanks for the contribution! |
phobologic
added a commit
that referenced
this pull request
Feb 21, 2013
adding support for autoscaling notification configurations
|
Awesome, thank you @turtlebender. |
Hons
pushed a commit
to Hons/troposphere
that referenced
this pull request
Dec 23, 2014
…-notification adding support for autoscaling notification configurations
markpeek
pushed a commit
that referenced
this pull request
May 3, 2020
* Update ApiStage to accept a dict for Throttle The docs are vague (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apigateway-usageplan-apistage.html), but Throttle needs to end up like this in cfn: ``` usagePlan: Type: 'AWS::ApiGateway::UsagePlan' Properties: ApiStages: - ApiId: <your API ID> Stage: <API Stage> Throttle: "<resource Path>": //(for example "/{item}/GET") BurstLimit: 10 RateLimit: 5 ```
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds first class support for the AutoScalingGroup NotificationConfigurations. I'll add at least one more example in the not too distant future