feat: add grpc_multi_service client #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsterDY
approved these changes
Jan 6, 2024
felix021
previously approved these changes
Jan 6, 2024
AsterDY
previously approved these changes
Jan 6, 2024
ViolaPioggia
force-pushed
the
grpc_multi_service
branch
from
f989336 to
ad6a0c8
Compare
li-jin-gou
approved these changes
Jan 6, 2024
a631807682
reviewed
Jan 8, 2024
| 3. 修改 main.go | ||
| ``` | ||
| func main() { | ||
| clienta := servicea.MustNewClient("servicea", client.WithHostPorts("127.0.0.1:8888")) |
There was a problem hiding this comment.
可能所有client都需要指定client.WithTransportProtocol(transport.GRPC)，我不确定（我后面提了个 issue 没再查了）。
我有一个multiservice s0
当服务s1使用了c1,c2指定了transport访问s0是成功的。
但后来发现别的服务s2只使用c1并不需要c2时，不指定transport访问仍然报找不到method。
There was a problem hiding this comment.
代码能够正常运行，这里的 clienta 是不需要指定 client.WithTransportProtocol(transport.GRPC) 的，当然指定了也不会有问题；如果想要实现 multiservice ，后续的 clientb 是需要指定 client.WithTransportProtocol(transport.GRPC) 的，否则就会如你所说出现找不到 method 的情况，后续我补充一下 README 吧
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
feat: add grpc_multi_service client