Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Git branch information is broken for submodules #833

Closed
gpakosz opened this issue Feb 10, 2016 · 3 comments
Closed

Git branch information is broken for submodules #833

gpakosz opened this issue Feb 10, 2016 · 3 comments
Assignees
@MartiUK
Labels
👆 clink-completions Upstream issue in clink-completions.
Milestone
1.4

Comments

@gpakosz
Copy link
Contributor

gpakosz commented Feb 10, 2016

When using Cmder with a cmd.exe session, Git branch information for submodules is broken.

This is directly related to clink-completions's get_git_dir() not handling submodules correctly.

I believe once vladimir-kotikov/clink-completions/issues/46 is closed, git_prompt_filter() which uses get_git_dir() will report the proper branch information.
@MartiUK MartiUK self-assigned this Feb 10, 2016
@MartiUK MartiUK added this to the 1.3 milestone Feb 10, 2016
@MartiUK MartiUK added the 👆 clink-completions Upstream issue in clink-completions. label Feb 10, 2016
@gpakosz gpakosz mentioned this issue Feb 15, 2016
Closed
Stanzilla added a commit that referenced this issue Feb 16, 2016
@Stanzilla
Merge pull request #841 from gpakosz/clink-git-prompt
c304290 
Fixed get_git_dir() to take submodules into account. Fixes #833
@gpakosz
Copy link
Contributor Author

gpakosz commented Feb 16, 2016

I thought the commit message would automatically close this issue.

@vladimir-kotikov
Copy link
Contributor

It will when commit appear in master branch. It has been merged into development yet.

@gpakosz
Copy link
Contributor Author

gpakosz commented Feb 16, 2016

I see. Thanks

sonictk pushed a commit to sonictk/cmder that referenced this issue May 21, 2016
@gpakosz @sonictk
Fixed get_git_dir() to take submodules into account. Fixes cmderdev#833
851ac82
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@MartiUK MartiUK

Labels
👆 clink-completions Upstream issue in clink-completions.
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
3 participants
@gpakosz @MartiUK @vladimir-kotikov