-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
New build and pack scripts #152
Conversation
This is all cool. I want to help out how should I edit your work on this commit (new to github here). Should we work on a powershell-build branch to be merged into master when finished? |
Amazing I think you can just do this. # Fork the repo
git clone <your fork>
git remote add upstream <this repo>
# You might have to do: git pull origin scripts
git checkout scripts # the working branch for the powershell scripts
# do stuff in scripts folder
git commit
git push origin scripts # you might need -u here to set the tracking
# Submit a pull request to cmder/scripts Then we can accept your changes and they will be listed under this pull request. Feel free to poke around in whatever you find interesting. I am not planning to do any work today nor tomorrow 🚲 so no necessary collisions should happen. |
Also when some changes happen on this branch I think you can do |
Do we want this for 1.1.4 considering the xp build nuances? |
I don't think its worth holding up a release to add this work. Get some of the other updates out to people is my opinion. |
incase url's that don't put the file in the url.
working script will; Remove existing folders named in the sources Download the packages listed in sources.json Extracts the above packages deletes the downloaded package
I guess I should reference #157 here. Looks like I need the hub project to add to this PR and it didn't work outright so I won't try to fix it to get through a proxy right now. |
Getting the build script to a working state
@Jackbennett And your commits are here! git-magic ⚡ |
This doesn't like folders in folders by the way.
|
I suppose you can do what I did in the ruby version. Just check the if extracted dir contains exactly one folder. If it does, just flatten it somehow, by using temp folder name like I did or just copy the contents. |
Removed some absolute path, and refactored the code so it handles the nested folder archives
Jack, can you please check the modified build and tell me what you think? |
@Jackbennett Do you have any experience with doing multiple threads in PS? Do you think that would be feasible do to extraction and downloading on different threads? |
Removed some absolute path, and refactored the code so it handles the nested folder archives
Conflicts: scripts/build.ps1
Some, but for the most part in my powershell needs it's been faster to leave the dumb sequential script I made in 2 minutes running and do another job than spend 20 minutes speeding it up. You need to use the start-job, wait-job, receive-job type cmdlets to start the function in the background and carry on. I wrote this but I can't remember why I scrapped that approach. I'm going to have another go now. I've read you changes but not run them myself so I've refrained from commenting. Will get back to you. I'm having a bit of a crazy week. |
…t can't be redirected along the pipeline. You couldn't pipe this output to a logfile.
…pt is doing. Adding some clearer dubugging info for cleaning up folders
Minor changes for #152
I started working on the pack an build scripts in Powershell. It makes much more sense and keeping ruby as a build requirement does not make any sense.
The other thing is the google code is pretty much dying. Clink has been migrated to github and conemu is using other distribution channels. Therefore I drafted
sources.json
- simple file that lists all the requirements for cmder. By using it, we will gain the power to control the versions of the software. I am hoping it can be turned into working updater one happy day.I have never touched powershell language until today. So bare with me.
ToDo
Build script
Pack script