-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add /x "CONEMU ARGS"
command line argument.
#2096
Add /x "CONEMU ARGS"
command line argument.
#2096
Conversation
This argument forwards parameters to ConEmu app. e.g. Cmder.exe /FWPARS "-min -tsa" In this case Cmder will start minimized on TaskBar
Thanks for the PR, I have not looked yet but will look later today when i get home. Initial thoughts and questions:
Just looked, no it is not.
Yes.
Yes
The issue I forsee is what if a conemu arg needs to be quoted. The approach I was looking at was just to compile all unknown args and pass them to conemu directly . This would avoid the quoted arg issue. I am having difficulty in figuring this out though due to data type diffs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have compiled and tested it here.
Please change the parameter to /conemu-args
so it is more intuitive and add to the Unreleased
section of the CHANGELOG.md
usint the same format that is used there.
Hi All,
below my replies:
* 1. Is the arg case sensitive? Hopefully not.
* No It is not.
* 2. Did you update the command line help?
* Yes I did.
* 3. Did you update the README.md with documentation
* Yes. I did.
* 4. Can you make the arg /conemu, seems more intuitive
* Yes OK. It seems better and more intuitive.
About the quoted conemu args I did not go in deeper but it dosen’t seem it has for now.
Regards
Ezio
Da: Dax T Games <notifications@github.com>
Inviato: domenica 12 maggio 2019 16:15
A: cmderdev/cmder <cmder@noreply.github.com>
Cc: Ezio Sella <E.Sella@bdfdigital.it>; Author <author@noreply.github.com>
Oggetto: Re: [cmderdev/cmder] Add FWPARS cmdline argument. (#2096)
Thanks for the PR, I have not looked yet but will look later today when i get home. Initial thoughts and questions:
1. Is the arg case sensitive? Hopefully not.
2. Did you update the command line help?
3. Did you update the README.md with documentation.
4. Can you make the arg /conemu, seems more intuitive.
The issue I forsee is what if a conemu arg needs to be quoted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2096 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAX7WKZNFDXO5KJOZU7AVKLPVAQ75ANCNFSM4HMKMH2A>.
|
OK I will.
Bye
Da: Dax T Games <notifications@github.com>
Inviato: domenica 12 maggio 2019 18:03
A: cmderdev/cmder <cmder@noreply.github.com>
Cc: Ezio Sella <E.Sella@bdfdigital.it>; Author <author@noreply.github.com>
Oggetto: Re: [cmderdev/cmder] Add FWPARS cmdline argument. (#2096)
@daxgames requested changes on this pull request.
I have compiled and tested it here.
Please change the parameter to /conemu-args so it is more intuitive and add to the Unreleased section of the CHANGELOG.md usint the same format that is used there.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2096 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAX7WKZOFYW2JDTASQJR7GDPVA5T3ANCNFSM4HMKMH2A>.
|
@eziosella I hope I did not discourage your participation by asking for changes. You still working on this? Or did you decide to tackle the quoting question I raised or maybe the forward all unknown args direct to conemu? You could just make this argument be |
@daxgames No discouraged, just been busy. About the |
/x "CONEMU ARGS"
command line argument.
@eziosella MERGED. Thanks again for the PR and the changes. |
This argument forwards parameters to ConEmu app.
In this case Cmder will start minimized on TaskBar