Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

vscode.bat #2113

Merged
merged 2 commits into from
Jun 27, 2019
Merged

vscode.bat #2113

merged 2 commits into from
Jun 27, 2019

Conversation

SupinePandora43
Copy link
Contributor

@SupinePandora43 SupinePandora43 commented Jun 25, 2019

add that to settings.json

"terminal.integrated.shell.windows": "cmd.exe",
"terminal.integrated.shellArgs.windows": [
    "/K",
    "%CMDER_ROOT%/vendor/bin/vscode_init.cmd",
]

for using cmder inside vscode.

simple .bat for starting init.bat if user manually opened console, and starting cmd.exe for task support

add that to settings.json

`"terminal.integrated.shell.windows": "cmd.exe",
"terminal.integrated.shellArgs.windows": [
    "/K",
    "%CMDER_ROOT%/vscode.bat",
]`

for using cmder inside vscode
@daxgames
Copy link
Member

@SupinePandora43 Does this address the cmder not working correctly with vscode tasks?

@SupinePandora43
Copy link
Contributor Author

SupinePandora43 commented Jun 25, 2019

@daxgames if use init.bat for integrated terminal in vscode, tasks don't work!

@daxgames
Copy link
Member

Thats what i thought, thanks.

@SupinePandora43
Copy link
Contributor Author

any review ?!

@MartiUK MartiUK self-requested a review June 26, 2019 10:51
@MartiUK MartiUK self-assigned this Jun 26, 2019
@daxgames
Copy link
Member

@SupinePandora43 Could you please move the file to %cmder_root%/vendor/bin/vscode_init.cmd and update the pr comment to reflect the new path. We keep all scripts owned by cmder in %cmder_root%/vendor/bin

@SupinePandora43
Copy link
Contributor Author

@daxgames done!

@daxgames daxgames merged commit ebd9777 into cmderdev:master Jun 27, 2019
@SupinePandora43
Copy link
Contributor Author

thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants