-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding script to enable SSH-agent #193 #352
Conversation
Adding agent-script to bin-folder and a commented out call in init.bat
Does this work if %HOME% has a space in it? |
Made a quick test on Win 8.1, and it does not. I'll take a loot at it, and maybe the original author, @Shoozza, has any ideas? |
@@ -44,3 +44,5 @@ | |||
@cd /d "%HOME%" | |||
) | |||
) | |||
|
|||
:: @call "%CMDER_ROOT%/bin/agent.cmd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add something to README.md telling users to uncomment this if needed? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartiUK , done.
About $HOME: You can usually fix it by turning on delayed expansion and use variables with !var! instead of %var%. Try that. |
Should be fixed in the latest gist https://gist.github.com/Shoozza/8fe8b0c85fa89cd3b1c4 |
Thanks, @Shoozza, this fixed the issue.
|
Are you confident this can be merged @ogrim? |
Just tested it again and it handles PATH with spaces (test home), so I am confident it is good, @MartiUK |
Alright cool. |
Adding script to enable SSH-agent #193
Adding agent-script to bin-folder and a commented out call in init.bat
Re-did it for the development branch, sorry about the mixup