More variable quoting in init.bat #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were problems when a path contained a parenthesis like `C:\temp\test (test)\` As a precaution, quote all variables when they are used in echo or set.
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| :: Find root dir | |||
| if not defined CMDER_ROOT ( | |||
| for /f "delims=" %%i in ("%ConEmuDir%\..\..") do set CMDER_ROOT=%%~fi | |||
| for /f "delims=" %%i in ("%ConEmuDir%\..\..") do set "CMDER_ROOT=%%~fi" | |||
There was a problem hiding this comment.
Are you sure you want to wrap the whole assignment within double quotes? The left side of assignment is basically declaring the variable/identifier, and should not need quotes. The right side instead is what might be affected by double quotes. Just to be sure, have you checked if it works jut with ..... do set CMDER_ROOT="%%~fi" ?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were problems when a path contained a parenthesis like
C:\temp\test (test)\As a precaution, quote all variables when they are used in echo or set.