Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#10] Store and pass the proxy response data as an Uint8Array instead of always decoding to a string #11

Merged
merged 4 commits into from
Nov 21, 2021

Conversation

cmorten
Copy link
Owner

@cmorten cmorten commented Nov 21, 2021

Issue

Fixes #10

Details

Don't blanket decode the response body to a string, instead leave as an Uint8Array for consumers to decode if appropriate. This is a breaking change for the srcResDecorator and filterRes option methods.

CheckList

  • PR starts with [#ISSUE_ID].
  • Has been tested (where required) before merge to main.

@cmorten cmorten self-assigned this Nov 21, 2021
@cmorten cmorten added the bug Something isn't working label Nov 21, 2021
@cmorten cmorten merged commit f521001 into main Nov 21, 2021
@cmorten cmorten deleted the fix/issue-10-corrupted-zip-proxy branch November 21, 2021 16:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archive files being corrupted by opine proxy
1 participant