Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add new methods to RobotModel and some other minor modificiations #74

Merged
merged 5 commits into from
Feb 19, 2023

Conversation

cmower
Copy link
Owner

@cmower cmower commented Feb 15, 2023

Adding several new methods to RobotModel. @joaomoura24 this probably won't be too bad to rebase #41 but happy to hold off till that is merged - let me know what you want to do.

@cmower cmower requested a review from joaomoura24 February 15, 2023 14:15
@cmower cmower mentioned this pull request Feb 15, 2023
@joaomoura24
Copy link
Collaborator

Yeah, i would hold this one because it will be easier to rebase this one with just 1 commit than the other PR.

@cmower
Copy link
Owner Author

cmower commented Feb 16, 2023

I've also added a small feature in 863f9ca. This does a check after solve is called and throws a RuntimeError when the solver failed to converge. This is an optional feature.

@cmower cmower changed the title Add new methods to RobotModel Add new methods to RobotModel and some other minor modificiations Feb 16, 2023
@joaomoura24 joaomoura24 mentioned this pull request Feb 17, 2023
@cmower cmower merged commit 3eeeaf3 into master Feb 19, 2023
@cmower cmower deleted the addr-issue-73 branch February 19, 2023 10:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants