Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add data Option for Matrix #130

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Add data Option for Matrix #130

merged 2 commits into from
Sep 9, 2024

Conversation

AdrianoDee
Copy link
Contributor

This PR proposes to add the data option for the matrix to the frontend (and the backend checks). This is needed since we have a new matrix with new data workflow to submit from 14_1_0_pre7.

@AdrianoDee
Copy link
Contributor Author

@ggonzr let me know if this works for you.

@ggonzr
Copy link
Contributor

ggonzr commented Aug 30, 2024

Thanks for the contribution.

This patch is available in the development environment. I tried to submit this ticket but there is an underlying issue about how the run_the_matrix_pdmv.py attempts to load a module from the cms-sw release:

def get_workflows_module(name):
"""
Load a specified module from Configuration.PyReleaseValidation
"""
workflows_module_name = 'Configuration.PyReleaseValidation.relval_' + name
workflows_module = importlib.import_module(workflows_module_name)
print('Loaded %s. Found %s workflows inside' % (workflows_module_name,
len(workflows_module.workflows)))
return workflows_module

The relval_data module does not exist (Unable to find it here). Please find the stack trace below:

File "<X>/run_the_matrix_pdmv.py", line 300, in <module>
main()

File "<X>/run_the_matrix_pdmv.py", line 239, in main
workflows_module = get_workflows_module(opt.matrix_name)

File "<X>/run_the_matrix_pdmv.py", line 96, in get_workflows_module
workflows_module = importlib.import_module(workflows_module_name)

File "/cvmfs/cms.cern.ch/el8_amd64_gcc12/external/python3/3.9.14-c10287ae9cadff55334e60003302c349/lib/python3.9/importlib/__init__.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)

File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
File "<frozen importlib._bootstrap>", line 984, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'Configuration.PyReleaseValidation.relval_data'

Is there any other cms-sw release that provides this module?

@AdrianoDee
Copy link
Contributor Author

Hi @ggonzr, this is because I had forgotten run_the_matrix_pdmv.py works differently from run_the_matrix.py. Should work now.

@ggonzr
Copy link
Contributor

ggonzr commented Aug 30, 2024

The module import issue is now solved but there's an issue related to the workflow IDs available in the ticket. 11741.0 is not a valid value. Do you know an expected workflow ID we can use in the test ticket?

@ggonzr
Copy link
Contributor

ggonzr commented Aug 30, 2024

I used this workflow ID 2024.4141 found in this PR description and now the ticket creation works.

@AdrianoDee
Copy link
Contributor Author

Perfect, that's the expected behavior.

@ggonzr ggonzr merged commit 7235149 into cms-PdmV:master Sep 9, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants