Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Scouting Offline DQM developments for 2025 #2432

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

elfontan
Copy link
Contributor

@elfontan elfontan commented Feb 4, 2025

This PR is assigning new code areas developed for the Scouting Offline DQM in PR#47235 to the dqm area:

  • DQMOffline/HLTScouting
  • HLTriggerOffline/Scouting

Thanks @mmusich for the pointer!

[cc: @silviodonato @missirol @mtosi]

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

A new Pull Request was created by @elfontan for branch master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

cms-bot internal usage

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 4, 2025

assign dqm

@cms-sw/dqm-l2 any objections?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

New categories assigned: dqm

@antoniovagnerini,@rseidita you have been requested to review this Pull request/Issue and eventually sign? Thanks

@antoniovagnerini
Copy link

assign dqm

@cms-sw/dqm-l2 any objections?

no objections from our side

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56c099/44206/summary.html
COMMIT: 49d35cd
CMSSW: CMSSW_15_0_X_2025-02-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2432/44206/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016960
  • DQMHistoTests: Total failures: 88
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4016852
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Feb 5, 2025

can this be merged?

@antoniovagnerini
Copy link

+1

@mandrenguyen
Copy link
Contributor

+1

@mandrenguyen
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ab53e2c into cms-sw:master Feb 5, 2025
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants