Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add a test workflow for testing the new @hltScouting DQM sequence in ScoutingPFMonitor dataset #47327

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 11, 2025

fixes #47315

PR description:

Title says it all

PR validation:

runTheMatrix.py -l 145.415 -t 4 -j 8 runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild cmsbuild added this to the CMSSW_15_1_X milestone Feb 11, 2025
@mmusich
Copy link
Contributor Author

mmusich commented Feb 11, 2025

test parameters:

  • workflow = 145.415

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 11, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 11, 2025

@cmsbuild, please test

@mmusich mmusich changed the title add a test workflow for testing the new @hltScouting DQM sequence in ScoutingPFMonitor dataset add a test workflow for testing the new @hltScouting DQM sequence in ScoutingPFMonitor dataset Feb 11, 2025
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1db4f/44332/summary.html
COMMIT: 76fee0d
CMSSW: CMSSW_15_1_X_2025-02-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47327/44332/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4019507
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4019466
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@silviodonato
Copy link
Contributor

In the DQM file of the PR test I see the scouting DQM folders as expected
Screenshot from 2025-02-12 18-54-33.

I'm just realizing that we should keep also the standard DQM in ScoutingPFMonitor, so
HARVESTING:@hltScouting -->
HARVESTING:@standardDQM+@miniAODDQM+@nanoAODDQM+@hltScouting

DQM:@rerecoZeroBias+@miniAODDQM+@nanoAODDQM -->
DQM:@standardDQM+@miniAODDQM+@nanoAODDQM+@hltScouting

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Copy link
Contributor Author

@mmusich mmusich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silviodonato, like this?

@silviodonato
Copy link
Contributor

Yes, I think so

add back `@standardDQM+@miniAODDQM+@nanoAODDQM` sequences to wf 145.415
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #47327 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 12, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1db4f/44360/summary.html
COMMIT: 253e316
CMSSW: CMSSW_15_1_X_2025-02-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47327/44360/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor

+pdmv

@Moanwar
Copy link
Contributor

Moanwar commented Feb 13, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow to test the new @hltScouting DQM sequence in ScoutingPFMonitor dataset
6 participants