Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Backport: Developing offline JetMET DQM for Scouting jets #47336

Merged
merged 29 commits into from
Feb 18, 2025

Conversation

etzovara
Copy link
Contributor

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of PR #47212. It includes the developments for JME in terms of the Scouting Offline DQM and it complements the PR #47235.

… energy fractions and multiplicities - also divided per eta region) + adding existent HLT PF JECs for scouting jets -> dividing into corrected/uncorrected kinematic distributions
… changed to scouting rho when 2025 datasets are available + removing unnecessary comments
…Source sequence to run with @hltscouting dqm sequence
@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Feb 12, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2025

A new Pull Request was created by @etzovara for CMSSW_15_0_X.

It involves the following packages:

  • DQMOffline/JetMET (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@ahinzmann, @gkasieczka, @jdamgov, @jdolen, @mariadalfonso, @mmarionncern, @nhanvtran, @rappoccio, @rociovilar, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2025

cms-bot internal usage

@etzovara etzovara changed the title Developing offline JetMET DQM for Scouting jets Backport: Developing offline JetMET DQM for Scouting jets Feb 12, 2025
@mmusich
Copy link
Contributor

mmusich commented Feb 12, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbce63/44354/summary.html
COMMIT: 00c6808
CMSSW: CMSSW_15_0_X_2025-02-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47336/44354/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 178 lines from the logs
  • Reco comparison results: 361 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016960
  • DQMHistoTests: Total failures: 6019
  • DQMHistoTests: Total nulls: 249
  • DQMHistoTests: Total successes: 4010672
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1186.8479999999995 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 20.921 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 10224.0,... ): 37.731 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 13234.0,... ): 16.811 KiB JetMET/Jet
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Feb 12, 2025

backport of #47212

@mmusich
Copy link
Contributor

mmusich commented Feb 14, 2025

@cmsbuild, please test workflow 145.415 with #47349

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbce63/44387/summary.html
COMMIT: 00c6808
CMSSW: CMSSW_15_0_X_2025-02-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47336/44387/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 178 lines from the logs
  • Reco comparison results: 354 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016960
  • DQMHistoTests: Total failures: 6041
  • DQMHistoTests: Total nulls: 249
  • DQMHistoTests: Total successes: 4010650
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1186.8479999999995 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 20.921 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 10224.0,... ): 37.731 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 13234.0,... ): 16.811 KiB JetMET/Jet
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b0ab531 into cms-sw:CMSSW_15_0_X Feb 18, 2025
20 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants