Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

XrdAdaptor: improve exception messages #47462

Merged
merged 2 commits into from
Mar 2, 2025

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Feb 26, 2025

PR description:

This PR extends the XrdAdaptor exception messages by

  • including information on inactive sources to the exceptions that include information on active and disabled sources.
  • the full new URL to the exceptions thrown from RequestManager::initialize()
    • the full new URL was already part of the exceptions thrown from RequestManager::OpenHandler::open()

These could be useful to investigate the logs of situations such as #43162

Resolves cms-sw/framework-team#1237

PR validation:

Code compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 15_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • Utilities/XrdAdaptor (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

The full new URL is already part of the exception message in OpenHandler::open()
@makortel makortel changed the title XrdAdaptor: Include information on inactive sources to exception messages XrdAdaptor: improve exception messages Feb 26, 2025
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #47462 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Contributor Author

FYI @bbockelm @dynamic-entropy

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-520440/44690/summary.html
COMMIT: 9ea9ade
CMSSW: CMSSW_15_1_X_2025-02-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47462/44690/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920256
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

Comparison differences are related to #47071

@makortel
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bd2f8c8 into cms-sw:master Mar 2, 2025
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve exception message
3 participants