Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move CPUServiceBase, RootHandlers, and TimingServiceBase to FWCore/AbstractServices #47466

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

makortel
Copy link
Contributor

PR description:

Following #47280 (where the package was created), motivated by #47175 (review). These three service base classes were "easy to move" from FWCore/Utilities. I envision two more PRs, one for RandomNumberGenerator and one for JobReport.

Resolves cms-sw/framework-team#1265

PR validation:

Code compiles

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47466/43898

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • FWCore/AbstractServices (core)
  • FWCore/Framework (core)
  • FWCore/Services (core)
  • FWCore/Utilities (core)
  • IOPool/Common (core)
  • IOPool/Output (core)
  • PerfTools/AllocMonitor (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@felicepantaleo, @fwyzard, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Contributor Author

@Dr15Jones Could you review?

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 96KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aabf2/44697/summary.html
COMMIT: 3386c6b
CMSSW: CMSSW_15_1_X_2025-02-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47466/44697/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 46
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920234
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

Comparison differences are related to #47071

#ifndef FWCore_Utilities_CPUServiceBase_h
#define FWCore_Utilities_CPUServiceBase_h
#ifndef FWCore_AbstractServices_interface_CPUServiceBase_h
#define FWCore_AbstractServices_interface_CPUServiceBase_h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not normally put _interface_ here. Should this be consistent or do you want to change all the other files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already some headers with _interface_ in FWCore. 4.1 in https://cms-sw.github.io/cms_coding_rules.html#4--technical-coding-rules-1 has the wording

If necessary to create a unique name, one can add the directory name

Strictly speaking the _interface is not necessary here, as there are no other headers with the same file name in this package.

I think the question of including _interface_ or not when not strictly necessary is somewhat of a personal taste, and I'd be fine with us not being fully consistent with that.

@makortel
Copy link
Contributor Author

makortel commented Mar 5, 2025

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d170a9b into cms-sw:master Mar 6, 2025
11 checks passed
@makortel makortel deleted the moveToAbstractServices branch March 6, 2025 14:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move those Service base classes that are straightforward to move
4 participants