Merge pull request #3572 from tvami/FixFilterEffNeg

Fix the case when filter eff is negative in the fragement
cms-sw · Dec 6, 2023 · dddd661 · dddd661
2 parents 7d0b328 + 5560060
commit dddd661
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/bin/utils/request_fragment_check.py b/bin/utils/request_fragment_check.py
@@ -635,7 +635,7 @@ def root_requests_from_ticket(ticket_prepid, include_docs=False):
         print("Filter efficiency in fragment =" + str(filter_eff_fragment))
         print("Filter efficiency from generator parameters field = "+str(filter_eff))
         # see https://github.com/cms-sw/genproductions/issues/3269
-        if len(filter_eff_fragment) > 0 and float(filter_eff_fragment) < 1.0:
+        if len(filter_eff_fragment) > 0 and float(filter_eff_fragment) < 1.0 and float(filter_eff_fragment) > 0:
             if filter_eff_fragment and filter_eff and int(ext) == 0 and float(filter_eff_fragment) != float(filter_eff):
                 errors.append("In general, filter efficiency in the fragment is not taken into accout. Please make sure that the filter efficiency in the generator parameters field is correct!")