This repository was archived by the owner on Jan 7, 2025. It is now read-only.
fix(bridge): handle information schema #245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi <iskyzh@gmail.com>
yliang412
reviewed
Nov 23, 2024
Comment on lines
+64
to
+81
| let (schema, table) = if let Some((schema, table)) = name.split_once('.') { | ||
| (schema, table) | ||
| } else { | ||
| ("public", name) | ||
| }; | ||
| let schema = if schema == "information_schema" { | ||
| // This is `INFORMATION_SCHEMA` but datafusion didn't expose this constant. | ||
| // Also, note that we didn't check `session_state.is_information_schema_enabled()` so this schema is always | ||
| // available. | ||
| Arc::new(InformationSchemaProvider::new(Arc::clone(&self.catalog))) | ||
| } else if let Some(schema) = catalog.schema(schema) { | ||
| schema | ||
| } else { | ||
| panic!("schema not found in datafusion catalog: {}", schema) | ||
| }; | ||
| let Some(table) = futures_lite::future::block_on(schema.table(table.as_ref())) else { | ||
| panic!("table not found in datafusion catalog: {}", name); | ||
| }; |
There was a problem hiding this comment.
I feel using datafusion's resolve method makes it cleaner:
https://github.com/cmu-db/optd/blob/d5b0239d22cc4416635a099830cd82da1491b7b8/optd-datafusion-bridge/src/lib.rs#L174-L181
I had it while drafting https://github.com/cmu-db/optd/pull/233
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information schema is not in datafusion's catalog. It is handled differently as in the upstream source code:
https://github.com/apache/datafusion/blob/c0ca4b4e449e07c3bcd6f3593fa31dd31ed5e0c5/datafusion/core/src/execution/session_state.rs#L301-L311
Therefore, we added this special case in the df-bridge.