Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Last-minute docs changes #1166

Merged
merged 2 commits into from
May 17, 2023
Merged

Last-minute docs changes #1166

merged 2 commits into from
May 17, 2023

Conversation

krivard
Copy link
Contributor

@krivard krivard commented May 17, 2023

Summary:

Final (?) sync with comms doc.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@krivard krivard marked this pull request as ready for review May 17, 2023 20:16
melange396
melange396 approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krivard krivard merged commit b5fbf70 into dev May 17, 2023
@krivard krivard deleted the krivard/api-keys-docs branch May 17, 2023 20:39
@krivard krivard mentioned this pull request May 18, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@melange396 melange396 melange396 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krivard @melange396