Fix dashboard signals parsing for dashboard queries #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melange396
requested changes
Jul 11, 2023
…les_count() + in check_signals_allowlist(). Changed request_signals from list to set in order to use `issubset()` function
dmytrotsko
force-pushed
the
fix_dashboard_signals_parsing
branch
from
58caadd to
17b98dd
Compare
dmytrotsko
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
melange396
approved these changes
Jul 12, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed dashboard signals parsing for dashboard queries.
Used parse_source_signal_sets() function to parse (source, signal) pairs
Prerequisites:
dev