moving quidel signals to non-public access #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
RoniRos
previously approved these changes
Aug 15, 2023
|
@RoniRos yep, mostly just making sure you are cool with the verbiage. thanks! |
|
Kudos, SonarCloud Quality Gate passed!
|
melange396
added a commit
that referenced
this pull request
Aug 17, 2023
* Performance testing testing workflow (#1253) * New CTIS publication (#1255) * Newer CTIS publication * bring loggers in sync and add multiproc capabilities (#1254) * add syntax feature documentation (#1256) * Newest CTIS publication * chore: sync to www-covidcast release v3.2.7 * moving quidel signals to non-public access (#1261) with integration tests! --------- Co-authored-by: Dmytro Trotsko <dmytrotsko@gmail.com> * chore: release delphi-epidata 4.1.8 --------- Co-authored-by: Dmytro Trotsko <dmytrotsko@gmail.com> Co-authored-by: Rostyslav Zatserkovnyi <zatserkovnyi.rostyslav@gmail.com> Co-authored-by: Alex Reinhart <areinhar@stat.cmu.edu> Co-authored-by: nmdefries <42820733+nmdefries@users.noreply.github.com> Co-authored-by: melange396 <george.haff@gmail.com> Co-authored-by: minhkhul <118945681+minhkhul@users.noreply.github.com> Co-authored-by: minhkhul <minhkhul@users.noreply.github.com> Co-authored-by: melange396 <melange396@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving quidel signals to non-public access
includes:
still needs:
automated integration tests(done)sources_protected_by_roles(in src/server/_security.py now)restrict_by_roles(in src/server/endpoints/covidcast.py now)