Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Highlight epidatr readiness #1458

Merged
merged 2 commits into from
May 30, 2024
Merged

Highlight epidatr readiness #1458

merged 2 commits into from
May 30, 2024

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented May 29, 2024

Addresses https://delphi-org.slack.com/archives/C028AUR6MV1/p1706908159673089?thread_ts=1706903688.300809&cid=C028AUR6MV1

Summary:

Say epidatr package is done and link to CRAN page. Add example use and de-emphasize legacy R use.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@nmdefries nmdefries requested review from a team and minhkhul and removed request for a team May 29, 2024 19:53
@@ -60,15 +75,14 @@ res = Epidata.covidcast('fb-survey', 'smoothed_cli', 'day', 'county', [20200401,
print(res['result'], res['message'], len(res['epidata']))
````

### R

### R (legacy)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"legacy"... dig it!

@nmdefries nmdefries requested a review from melange396 May 30, 2024 15:37
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nmdefries nmdefries merged commit 058489f into dev May 30, 2024
7 checks passed
@nmdefries nmdefries deleted the ndefries/epidatr-ready-text branch May 30, 2024 17:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants