Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: Python client logger import #1460

Merged
merged 3 commits into from
May 31, 2024
Merged

fix: Python client logger import #1460

merged 3 commits into from
May 31, 2024

Conversation

dshemetov
Copy link
Contributor

Summary:

  • add delphi-utils as dependency to Python client
  • import logger from delphi-utils instead of locally
  • unpin delphi-utils in both requirements files

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dshemetov
fix: Python client logger import
093208d 
* add delphi-utils as dependency to Python client
* import logger from delphi-utils instead of locally
* unpin delphi-utils in both requirements files
@dshemetov dshemetov requested a review from melange396 May 30, 2024 21:34
melange396
melange396 approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

groovy

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@melange396 melange396 merged commit 3673ac9 into dev May 31, 2024
6 checks passed
@melange396 melange396 deleted the ds/logger-fix branch May 31, 2024 13:59
@melange396 melange396 mentioned this pull request May 31, 2024
Merged
@boxydog boxydog mentioned this pull request Jun 3, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@melange396 melange396 melange396 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshemetov @melange396