Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Renamed several files in the covidcast signals folder #1476

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

tinatownes
Copy link
Collaborator

Removed -inactive, and renamed quidel files to distinguish covid and flu.

closes|addresses

Summary:

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Removed -inactive, and renamed quidel files to distinguish covid and flu.
@tinatownes tinatownes requested a review from nmdefries June 14, 2024 01:34
@tinatownes tinatownes self-assigned this Jun 14, 2024
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual changes look good, but I realized that these pages may be linked elsewhere, e.g.. We'd need to update those URLs too to make sure we don't break the links.

Based on the example search results above, this will span multiple repositories, so may be easier for me to do. I think it will affect quidel more than the other pages because the original renaming from, e.g., "safegraph" -> "safegraph-inactive" probably wasn't accompanied by link renaming in other repos.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nmdefries
Copy link
Contributor

Not breaking links to doc pages was easiest by keeping the active (covid) quidel doc file named quidel.md instead of quidel-covid.md; the only other link that needed to be updated was an .../indicator-combination-inactive.html in this repo. No other outdated URLs exist in this repo or other Delphi repos.

@nmdefries nmdefries self-requested a review June 17, 2024 21:32
@nmdefries nmdefries merged commit 27b54fc into dev Jun 17, 2024
7 checks passed
@nmdefries nmdefries deleted the Tina_renaming_inactive_files branch June 17, 2024 21:34
@@ -19,7 +19,7 @@ safegraph,safegraph-weekly,SafeGraph (Weekly),[SafeGraph](https://docs.safegraph
usa-facts,usa-facts,USAFacts,USAFacts is a nonprofit that aggregates and standardizes a vast array of data from US government agencies. This source reports confirmed COVID-19 cases and deaths.,confirmed_incidence_num,CC BY,,[API Documentation](https://cmu-delphi.github.io/delphi-epidata/api/covidcast-signals/usa-facts.html)
ght,ght,Google Health Trends,"Google Health Trends tracks Google searches on health-related topics. This source includes Google Health Trends API results for overall searcher interest in a set of COVID-19 related terms about anosmia (lack of smell or taste), which emerged as a symptom of the coronavirus. No longer updated after March 8, 2021.",smoothed_search,unknown,,[API Documentation](https://cmu-delphi.github.io/delphi-epidata/api/covidcast-signals/ght.html)
google-survey,google-survey,Google Symptom Surveys,"Delphi ran symptom surveys using a Google tool which collects responses through publisher websites, Google's Opinions Reward app, and similar applications. No longer updated after May 15, 2020.",smoothed_cli,CC BY,,[API Documentation](https://cmu-delphi.github.io/delphi-epidata/api/covidcast-signals/google-survey.html)
indicator-combination,indicator-combination-nmf,Statistical Combination (NMF),"This source provides signals which are statistical combinations of other sources, calculated by Delphi. It is not a primary data source. No longer updated after March 17, 2021.",nmf_day_doc_fbs_ght,CC BY,,[API Documentation](https://cmu-delphi.github.io/delphi-epidata/api/covidcast-signals/indicator-combination-inactive.html)
indicator-combination,indicator-combination-nmf,Statistical Combination (NMF),"This source provides signals which are statistical combinations of other sources, calculated by Delphi. It is not a primary data source. No longer updated after March 17, 2021.",nmf_day_doc_fbs_ght,CC BY,,[API Documentation](https://cmu-delphi.github.io/delphi-epidata/api/covidcast-signals/indicator-combination.html)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinatownes did you put these changes into the gsheet too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder! @tinatownes, I'll leave this to you. This needs to be changed on the "Data sources" tab.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants