Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace contingency codebook with updated one from Gdrive that includes missing indicators #1483

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Replace contingency codebook with updated one from Gdrive that includes missing indicators #1483

merged 1 commit into from
Jun 25, 2024

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jun 24, 2024 •
edited
Loading

Summary:

Updated from https://docs.google.com/spreadsheets/d/14Qp85hNwCV9NnzQz-sYZdtu_I-AUyeObY80SMuOi_-o/edit?gid=333745196#gid=333745196

Removes "Active" and "To add" columns. Adds ~200 missing indicators.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@nmdefries nmdefries requested a review from capnrefsmmat June 24, 2024 18:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

capnrefsmmat
capnrefsmmat approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- I only spot-checked this, but it looks good. And much longer than the existing one, which is good.

@capnrefsmmat capnrefsmmat merged commit bb35b47 into dev Jun 25, 2024
6 of 7 checks passed
@capnrefsmmat capnrefsmmat deleted the ndefries/fb-codebook-update branch June 25, 2024 14:15
@melange396 melange396 mentioned this pull request Jul 9, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@capnrefsmmat capnrefsmmat capnrefsmmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmdefries @capnrefsmmat