Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: wrong blame commit #1495

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix: wrong blame commit #1495

merged 1 commit into from
Jul 18, 2024

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Jul 17, 2024 •
edited
Loading

Ignore the right blame commit this time. See #1488 (comment). 81179c5

@dshemetov
fix: wrong blame commit
546f2f6 
Ignore the right blame commit this time. See #1488 (comment).
@dshemetov dshemetov requested a review from melange396 July 17, 2024 23:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

melange396
melange396 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you!

@melange396 melange396 merged commit 46a46a2 into dev Jul 18, 2024
7 checks passed
@melange396 melange396 deleted the dshemetov-patch-1 branch July 18, 2024 01:35
@melange396
Copy link
Collaborator

perfect now! https://github.com/cmu-delphi/delphi-epidata/blame/dev/src/acquisition/covidcast/database.py#L125

@minhkhul minhkhul mentioned this pull request Jul 18, 2024
Closed
@minhkhul minhkhul mentioned this pull request Jul 29, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@melange396 melange396 melange396 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshemetov @melange396