Skip to content

A new strict JSON highlighter #14

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 8, 2014
Merged

A new strict JSON highlighter #14

merged 1 commit into from
Oct 8, 2014

Conversation

iarna
Copy link
Contributor

@iarna iarna commented Sep 18, 2014

So previously we were just using the js highlighter for json, but that's not actually desirable as json doesn't accept lots of stuff that js does. So I wrote this new json highlighter from scratch based on json.org– this should be complete to the point of highlighting any invalid JSON.

@iarna iarna force-pushed the new-json branch 4 times, most recently from 76929ef to 732dfcf Compare September 18, 2014 05:19
@iarna
Copy link
Contributor Author

iarna commented Oct 8, 2014

Hi, just reminding you this is here. =)

@cmur2
Copy link
Owner

cmur2 commented Oct 8, 2014

Ah, nice! Seems to work fine and also recognizes [] just like {} :)
But the handling of escape sequences changed because now the initial backslash isn't bold anymore - deliberately? (It's not dealbreaking and one could argue that this allows to focus more on the meaning of the escape sequence since this backslash is always there but at least in my scenarios it's now easier to overlook short escape sequences hidden in longer strings...)

@iarna
Copy link
Contributor Author

iarna commented Oct 8, 2014

Nope– I'll update the pull request

@iarna
Copy link
Contributor Author

iarna commented Oct 8, 2014

Updated =) (Also fixed a bug where \ was showing as an error)

@cmur2
Copy link
Owner

cmur2 commented Oct 8, 2014

Yea, I noticed the \ problem too but assumed it was really a fault of mine ^^ Thank, will merge now.

cmur2 pushed a commit that referenced this pull request Oct 8, 2014
A new strict JSON highlighter
@cmur2 cmur2 merged commit 4d028bc into cmur2:master Oct 8, 2014
@iarna iarna deleted the new-json branch October 8, 2014 09:20
@cmur2
Copy link
Owner

cmur2 commented Mar 3, 2015

Hi, I'm currently in the process of trying to get all the contributions to the original JOE project (http://sourceforge.net/projects/joe-editor/) and wanted to ask kindly if you are willing to put your file under the GPL v2 license? This would be needed in order to comply with the license of the original JOE project. No problem if you decline, though :)

@iarna
Copy link
Contributor Author

iarna commented Mar 3, 2015

Absolutely. In fact, dual licensed, GPL v2 and ISC:

Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies.

THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

@cmur2
Copy link
Owner

cmur2 commented Mar 3, 2015

Wonderful, thanks!

@cmur2
Copy link
Owner

cmur2 commented Mar 10, 2015

Might you extend your statement to "GPL v2 or any later version"? The original JOE project evaluated their licensing situation and would like to have the any-later-version option to be better prepared for future developments... I already updated this for myself in the README.

@iarna
Copy link
Contributor Author

iarna commented Mar 10, 2015

Sure. (Of course, ISC above, is permissive enough that I could have JUST licensed it under that and it'd be compatible with any version of the GPL.)

@cmur2
Copy link
Owner

cmur2 commented Mar 10, 2015

Thanks. (Yea I guessed something like that but I'm not soo deep into license compatibility and didn't use ISC before...) Sorry for the trouble.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants