Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Basic tooling: link & spell check, and formatting #231

Merged
merged 1 commit into from
May 14, 2024
Merged

Basic tooling: link & spell check, and formatting #231

merged 1 commit into from
May 14, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented May 14, 2024 •
edited
Loading

  • Drops .vscode; moves the cSpell config to the top level
  • Adds an NPM package with scripts to check spelling, links, and formatting, as well as fix formatting

/cc @dwelsch-esi

@chalin chalin requested a review from nate-double-u May 14, 2024 15:59
@chalin chalin force-pushed the chalin-im-cspell-2024-05-14 branch from 2a04250 to baf5c5c Compare May 14, 2024 16:00
@chalin
Basic tooling: link & spell chack, and formatting
a8c473c 
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin chalin force-pushed the chalin-im-cspell-2024-05-14 branch from baf5c5c to a8c473c Compare May 14, 2024 16:08
@chalin chalin changed the title Basic tooling: spell check and formatting Basic tooling: link & spell check, and formatting May 14, 2024
@chalin
Copy link
Collaborator Author

chalin commented May 14, 2024

We'll soon be able to catch errors like those reported by this PR earlier:

@chalin chalin added the CI/infra CI & infrastructure label May 14, 2024
@chalin chalin mentioned this pull request May 14, 2024
Closed
2 tasks
nate-double-u
nate-double-u approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this tooling, @chalin!

@nate-double-u nate-double-u merged commit c96c55f into cncf:main May 14, 2024
1 check passed
@chalin chalin deleted the chalin-im-cspell-2024-05-14 branch May 14, 2024 20:04
@nate-double-u nate-double-u mentioned this pull request Aug 21, 2024
Draft
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

Assignees
No one assigned
Labels
CI/infra CI & infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @nate-double-u