Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Static analysis shouldn't be stopped in case of parsing error #154

Closed
WaldoFR opened this issue Sep 12, 2018 · 0 comments
Closed

Static analysis shouldn't be stopped in case of parsing error #154

WaldoFR opened this issue Sep 12, 2018 · 0 comments
Assignees
@WaldoFR
Labels
enhancement

Comments

@WaldoFR
Copy link

WaldoFR commented Sep 12, 2018

Expected behavior

Static analysis shouldn't be stopped in case of parsing problem, it should be raised inside a specialized rule showing the problem.

Actual behavior

Analysis are stoped when JFlex is reaching a parsing problem, causing the analysis to crash.

Steps to reproduce behavior

Analyzing for instance non-UNIX compliant encoded files.

Detection version

3.0.1
@WaldoFR WaldoFR self-assigned this Sep 12, 2018
WaldoFR pushed a commit that referenced this issue Sep 13, 2018
Fix #154 rename rule to ICODE.ERROR
1726152
@WaldoFR WaldoFR mentioned this issue Sep 13, 2018
Merged
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
Fix cnescatlab#154 raise violations instead of crash in case of parsi…
dc6316b 
…ng problem

Modifications were made by adding a "Parsing error" rule and to raise it
on JFlexException throwing instead of making the analysis stop.
begarco pushed a commit that referenced this issue Feb 2, 2020
Fix #154 raise violations instead of crash in case of parsing problem
293b238 
Modifications were made by adding a "Parsing error" rule and to raise it
on JFlexException throwing instead of making the analysis stop.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@WaldoFR WaldoFR

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WaldoFR