Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

plugin fr.cnes.analysis.tools.analyzer should not depend on org.eclipse.ui #35

Closed
opcoach opened this issue Jun 16, 2017 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@opcoach
Copy link
Contributor

opcoach commented Jun 16, 2017

This plugin is a core plugin without any UI concerns.

It must absolutely not depend on org.eclipse.ui. If we remove this dependency there is only one error on : PlatformUI.getPreferenceStore() to get ANALYZER_EP_CONTRIBUTOR_CHECK_ID.

It is better to use the IEclipsePreferenceService class like this (example found in FileHelper.class) :

	String defaultLineDelimiter = Platform.getPreferencesService().getString(Platform.PI_RUNTIME,
			Platform.PREF_LINE_SEPARATOR, platformDefaultLineDelimiter, null);
@WaldoFR WaldoFR self-assigned this Jun 20, 2017
@WaldoFR WaldoFR added this to the Version 3.0 milestone Jul 5, 2017
@WaldoFR WaldoFR closed this as completed Jul 5, 2017
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
Now verifying that a rule is contributing to the analyzer before running
it instead of checking it in preferences.
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
Now verifying that a rule is contributing to the analyzer before running
it instead of checking it in preferences.
begarco pushed a commit that referenced this issue Feb 2, 2020
Now verifying that a rule is contributing to the analyzer before running
it instead of checking it in preferences.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants