Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

3.1.0 alpha.4 #148

Merged
merged 4 commits into from
Aug 24, 2018
Merged

3.1.0 alpha.4 #148

merged 4 commits into from
Aug 24, 2018

Conversation

brigittehuynh
Copy link
Collaborator

@brigittehuynh brigittehuynh commented Aug 22, 2018

 - Awk command handling
 - Quotes and double quotes handling
 - Cases statements handling
 - Analysis failure on braces (issue due to [[)

The following issues no longer occur although there was no specific
correction for them. The overall modifications of the rule must have
resolved them:
 - Comments handling
 - Forbidden increasing of identation not handled
the COM.FLOW.FileExistence rule for recognizing file strings and adding
file management commands.
The tests files were updated accordingly.
its test files as it seems to be working correctly.
Copy link

@WaldoFR WaldoFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@WaldoFR WaldoFR merged commit 00f3a46 into v3.1.0-dev Aug 24, 2018
@WaldoFR WaldoFR deleted the 3.1.0-alpha.4 branch September 20, 2018 07:50
begarco pushed a commit to begarco/i-CodeCNES that referenced this pull request Jan 25, 2020
begarco pushed a commit that referenced this pull request Feb 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants