refactor pkg/kind #482
Merged
refactor pkg/kind #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doing this was suggested in #480 (review) |
squidboylan
force-pushed
the
refactor-pkg/kind
branch
2 times, most recently
from
ba2d9ef to
1a1e87a
Compare
nabuskey
reviewed
Feb 4, 2025
squidboylan
force-pushed
the
refactor-pkg/kind
branch
3 times, most recently
from
ac38438 to
a133dcd
Compare
|
/e2e |
nabuskey
reviewed
Feb 21, 2025
refactors pkg/kind/cluster.go into pkg/kind/config.go in order to simplify testing and adds relevant tests for the new utility functions. Also cleans up some unnecessary code in pkg/kind/cluster_test.go Signed-off-by: Caleb Boylan <calebboylan@gmail.com>
squidboylan
force-pushed
the
refactor-pkg/kind
branch
from
a133dcd to
104c955
Compare
|
/e2e |
nabuskey
approved these changes
Feb 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors pkg/kind/cluster.go into pkg/kind/config.go in order to simplify testing and adds relevant tests for the new utility functions. Also cleans up some unnecessary code in pkg/kind/cluster_test.go