Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

🐛 fix(popup): Make link to url target blank #65

Merged
merged 1 commit into from
Mar 16, 2023
Merged

🐛 fix(popup): Make link to url target blank #65

merged 1 commit into from
Mar 16, 2023

Conversation

vvatelot
Copy link
Member

No description provided.

@vvatelot vvatelot requested a review from jpkha March 15, 2023 12:34
jpkha
jpkha reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@jpkha jpkha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je viens de penser mais les bonnes pratiques de sécurité c'est de rajouter le rel=noopener, noreferrer à tous les <a> qui ont un target= _blank

@vvatelot
Copy link
Member Author

Est ce que tu penses que c'est nécessaire dans le cas d'un plugin ?

@vvatelot vvatelot self-assigned this Mar 15, 2023
@jpkha
Copy link
Contributor

jpkha commented Mar 16, 2023

Non pas nécessairement.

@vvatelot vvatelot merged commit 7d08aa5 into main Mar 16, 2023
@vvatelot vvatelot deleted the fix/popup-click-link branch March 16, 2023 07:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jpkha jpkha jpkha approved these changes

Assignees

@vvatelot vvatelot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvatelot @jpkha