Skip to content

Make default max_python 3.13 due to its release #43

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/tox.yml
Original file line number Diff line number Diff line change
@@ -26,9 +26,11 @@ jobs:
outputs:
matrix: ${{ steps.generate_matrix.outputs.matrix }}
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Determine matrix
id: generate_matrix
uses: coactions/matrix@main
uses: ./
with:
min_python: "3.10"
max_python: "3.13"
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ projects using:

## Supported optional arguments:

- `min_python` - Minimal version of python to be tested against, default is `"3.8"`. The maximum value is currently `"3.13"`
- `min_python` - Minimal version of python to be tested against, default is `"3.8"`. The maximum value is currently `"3.14"`
- `other_names`- A list of other tox environments to include in the matrix. We
plan to read them from [envlist](https://tox.wiki/en/latest/config.html#envlist) field in `tox.ini`.
- `platforms` - Default to `linux` only but can be `linux`, `windows`, `macos`
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ inputs:
max_python:
description: Maximal version of python to be tested against.
required: false
default: "3.12"
default: "3.13"
default_python:
description: Default version of python used by env.
required: false
8 changes: 4 additions & 4 deletions entrypoint.py
Original file line number Diff line number Diff line change
@@ -9,9 +9,9 @@

from actions_toolkit import core

KNOWN_PYTHONS = ("3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13-dev")
KNOWN_PYTHONS = ("3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14-dev")
PYTHON_REDIRECTS = {
"3.13": "3.13-dev", # Remove once GHA allows 3.13 as a valid version
"3.14": "3.14-dev", # Remove once GHA allows 3.14 as a valid version
}
PLATFORM_MAP = {
"linux": "ubuntu-24.04",
@@ -104,7 +104,7 @@ def main() -> None: # noqa: C901,PLR0912,PLR0915
core.debug(f"Testing strategy: {strategies}")

result: dict[str, dict[str, str]] = {}
if max_python == "3.13":
if max_python == "3.14":
python_names = KNOWN_PYTHONS[KNOWN_PYTHONS.index(min_python) :]
else:
python_names = KNOWN_PYTHONS[
@@ -144,7 +144,7 @@ def sort_key(s: str) -> tuple[int, str]:
"os": PLATFORM_MAP[platform_name],
}
for index, command in enumerate(commands[1:]):
data[f"command{index+2}"] = command
data[f"command{index + 2}"] = command
add_job(
result,
name,