Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sankey visualization is not legible for porecamp data #8

Closed
tayabsoomro opened this issue Aug 14, 2018 · 3 comments
Closed

Sankey visualization is not legible for porecamp data #8

tayabsoomro opened this issue Aug 14, 2018 · 3 comments
Labels
bug Something isn't working explore need to do information hunting to find answer

Comments

@tayabsoomro
Copy link
Member

The Sankey visualization needs to be altered in a way that it is legible, because with sequence runs having longer kraken report outputs, the Sankey visualization becomes less legible. Example shown below for porecamp data:

screen shot 2018-08-13 at 7 18 53 pm
@tayabsoomro tayabsoomro added bug Something isn't working explore need to do information hunting to find answer labels Aug 14, 2018
@tayabsoomro
Copy link
Member Author

The commit 1cdc7b9, which removed the label and only showed it on hover also doesn't seem to be a viable solution as it is extremely sluggish. Making the labels angled or vertical might make it a little better, but that still will not be absolutely perfect solution. Another thought is to make only the labels for the leaves visible and have everything else hidden, as ultimately leaves are what actually matter.

@tayabsoomro
Copy link
Member Author

tayabsoomro commented Aug 20, 2018

The react-vis library updated the code (uber/react-vis@9b7dd29), which enables us to set an angle to the labels using labelRotation={angle}. I experimented it with also only printing the label for terminal nodes and the output looks promising, however the branches are too close together:

screen shot 2018-08-20 at 12 17 27 pm

Results for porecamp data:

screen shot 2018-08-20 at 12 47 04 pm

I have opened another issue at react-vis repo (uber/react-vis#913), asking them if there is a solution for that.

@tayabsoomro
Copy link
Member Author

The issue has been fixed. Below is the updated result:

screen shot 2018-08-21 at 2 59 57 pm

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working explore need to do information hunting to find answer
Projects
None yet
Development

No branches or pull requests

1 participant