Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Exclude pip 9.0.2 specifically from test-requirements #2404

Closed
virresh opened this issue Apr 6, 2018 · 8 comments · Fixed by #2497
Closed

Exclude pip 9.0.2 specifically from test-requirements #2404

virresh opened this issue Apr 6, 2018 · 8 comments · Fixed by #2497

Comments

@virresh
Copy link
Member

virresh commented Apr 6, 2018

Due to a recent pip update to 9.0.3 that reverts the changes brought in pip 9.0.2, we should ideally just bar pip 9.0.2 and allow other versions here

Relevant links :
#2359
pypa/pip#5081 (comment)

@jayvdb
Copy link
Member

jayvdb commented Apr 6, 2018

And also prevent use of pip 10.0, but allow pip 10.1 , basically preparing for 10.0 being quite disruptive, but the problems will sort themselves out by 10.1

@aadilmehdis
Copy link

aadilmehdis commented May 15, 2018

Hi, I'd like to work on this issue as a newcomer, can you help me get started?
@virresh

@virresh
Copy link
Member Author

virresh commented May 15, 2018

Hello @aadilmehdis
You need to modify this line appropriately for the purpose of this issue.

If you would like an insight into what the actual problem is, consider reading the related links in the description

Also probably requirements specifiers might be useful for this issue

Head over to the gitter channel if you feel stuck

@aadilmehdis
Copy link

What versions of pip are to be excluded @virresh.
From the comments, I understand that the version 9.0.2 and 10.0 are to be specifically excluded.

@virresh
Copy link
Member Author

virresh commented May 20, 2018

@aadilmehdis
Yes, we need to specifically exclude version 9.0.2 and 10.0

@aadilmehdis
Copy link

@virresh
Hey, so making this change in the line would be okay?
pip<=9.0.3 , != 9.0.2, != 10.0.*

@virresh
Copy link
Member Author

virresh commented May 21, 2018

Why would you use <= 9.0.3 ?
I think the two latter specifiers should suffice.

@aadilmehdis
Copy link

Okay. Now to push in the changes, I just commit the changes and push my development branch and create a pull request right?

aadilmehdis pushed a commit to aadilmehdis/coala-bears that referenced this issue May 21, 2018
Made changes to bar the pip versions 9.0.2 and 10.0
specifically from in the test-requirements.txt.

Fixes coala#2404
aadilmehdis pushed a commit to aadilmehdis/coala-bears that referenced this issue May 22, 2018
Made changes to bar the pip versions 9.0.2 and 10.0
specifically from in the test-requirements.txt.

Fixes coala#2404
aadilmehdis pushed a commit to aadilmehdis/coala-bears that referenced this issue May 22, 2018
Made changes to bar the pip versions 9.0.2 and 10.0
specifically from in the test-requirements.txt.

Fixes coala#2404
aadilmehdis pushed a commit to aadilmehdis/coala-bears that referenced this issue May 25, 2018
Made changes to bar the pip versions 9.0.2 and 10.0
specifically from in the test-requirements.txt.

Fixes coala#2404
aadilmehdis pushed a commit to aadilmehdis/coala-bears that referenced this issue May 29, 2018
Made changes to bar the pip versions 9.0.2 and 10.0
specifically in the test-requirements.txt.

Fixes coala#2404
aadilmehdis pushed a commit to aadilmehdis/coala-bears that referenced this issue May 29, 2018
Made changes to specifically bar the pip versions 9.0.2 and
10.0 in test-requirements.txt.

Fixes coala#2404
aadilmehdis pushed a commit to aadilmehdis/coala-bears that referenced this issue May 29, 2018
Made changes to specifically bar the pip versions 9.0.2 and
10.0 in test-requirements.txt.

Fixes coala#2404
aadilmehdis pushed a commit to aadilmehdis/coala-bears that referenced this issue May 29, 2018
Made changes to specifically bar pip versions 9.0.2 and
10.0 in test-requirements.txt.

Fixes coala#2404
aadilmehdis pushed a commit to aadilmehdis/coala-bears that referenced this issue Jun 4, 2018
Made changes to specifically bar pip versions 9.0.2 and
10.0 in test-requirements.txt

Fixes coala#2404
aadilmehdis pushed a commit to aadilmehdis/coala-bears that referenced this issue Jun 11, 2018
Made changes to specifically bar pip versions 9.0.2 and
10.0 in test-requirements.txt

Fixes coala#2404
gitmate-bot pushed a commit to aadilmehdis/coala-bears that referenced this issue Jun 12, 2018
Made changes to specifically bar pip versions 9.0.2 and
10.0 in test-requirements.txt

Fixes coala#2404
gitmate-bot pushed a commit to aadilmehdis/coala-bears that referenced this issue Jun 13, 2018
Made changes to specifically bar pip versions 9.0.2 and
10.0 in test-requirements.txt

Fixes coala#2404
# for free to join this conversation on GitHub. Already have an account? # to comment
4 participants