Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI Deps: Pip version pin to 9.0.1 #2360

Merged
merged 1 commit into from
Mar 18, 2018
Merged

Conversation

virresh
Copy link
Member

@virresh virresh commented Mar 18, 2018

Closes #2359

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • [x ] I read the commit guidelines and I've followed
    them.
  • [ x] I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@jayvdb
Copy link
Member

jayvdb commented Mar 18, 2018

Need to also add it to dev-requirements.txt, otherwise this will hit Travis soon

@virresh
Copy link
Member Author

virresh commented Mar 18, 2018

Oh
okay sure,
I will update that as well :)

@jayvdb
Copy link
Member

jayvdb commented Mar 18, 2018

ack 75666a6

@jayvdb
Copy link
Member

jayvdb commented Mar 18, 2018

@gitmate-bot ff

@gitmate-bot
Copy link
Collaborator

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link
Collaborator

Automated fastforward with GitMate.io was successful! 🎉

@gitmate-bot gitmate-bot merged commit 75666a6 into coala:master Mar 18, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

Circle Ci failing due to pip version update
3 participants