Put define-class tests into a single suite file #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Izaakwltn
approved these changes
Oct 2, 2024
| --> test:3:33 | ||
| | | ||
| 3 | (define-class (C :a :b (:a :b ->))) | ||
| | ^ expected one or more type variables |
There was a problem hiding this comment.
This seems like a sketchy error message (outside of the scope of this PR)
| error: Malformed functional dependency | ||
| --> test:3:23 | ||
| | | ||
| 3 | (define-class (C :a :b (-> :b :c))) |
There was a problem hiding this comment.
This too, it should probably refer to the arrow, similarly to the => errors above .
(Once again, probably a separate PR)
| --> test:3:14 | ||
| | | ||
| 3 | (define-class (C :a :b =>)) | ||
| | ^^^^^^^^^^^^ missing class name |
There was a problem hiding this comment.
(subsequent PR) this is a suboptimal error, the class name is right there
| --> test:3:34 | ||
| | | ||
| 3 | (define-class (C :a :b (:a -> :b) :c)) | ||
| | ^^ expected a list |
There was a problem hiding this comment.
One more- I'm not sure what this error should be but this seems not ideal
| --> test:3:31 | ||
| | | ||
| 3 | (define-class (Eq :a => (C :a) :b)) | ||
| | ^^ unexpected form |
There was a problem hiding this comment.
Would be better to have a "trailing" error, though might be awkward to implement
stylewarning
approved these changes
Oct 2, 2024
jbouwman
force-pushed
the
define-class-tests
branch
from
cd24564 to
9e10c3a
Compare
Combine the programs and error messages in tests/parser-test-files/good-files/define-class.coal and tests/parser-test-files/bad-files/define-class.* into define-class.txt A structured input format is documented in tests/parser-test-files/README.md. It supports: - reexecution of single cases - selective test disabling - optional error message checking - test numbering And provides a place to put additional test metadata. The tests now compile their inputs, in addition to parsing.
jbouwman
force-pushed
the
define-class-tests
branch
from
9e10c3a to
32fb033
Compare
This was referenced Oct 2, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the programs and error messages in tests/parser-test-files/good-files/define-class.coal and tests/parser-test-files/bad-files/define-class.* into define-class.txt
A structured input format is documented in tests/parser-test-files/README.md. It supports:
And provides a place to put additional test metadata.
The tests now compile their inputs, in addition to parsing.
This incorporates changes from #1272 but only converts define-class tests and leaves others intact.