extensive usage of Result in main #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for further info see rust-lang-deprecated/error-chain#65 Signed-off-by: benaryorg <binary@benary.org>
Signed-off-by: benaryorg <binary@benary.org>
Signed-off-by: benaryorg <binary@benary.org>
Signed-off-by: benaryorg <binary@benary.org>
|
Oh yeah, I forgot: I linked to rust-lang-deprecated/error-chain#65 in e6cf321; should there be a new release of error-chain; please throw out that git stuff immediately and replace it by an actual version. |
|
Sorry. Forgot |
Signed-off-by: benaryorg <binary@benary.org>
|
New version of error-chain renders the above comment obsolete. |
|
Closed by #291 |
epage
added a commit
to epage/cobalt.rs
that referenced
this pull request
Oct 18, 2018
Breaking Changes * **for_block:** make ranges inclusive. ([42055c35](cobalt-org/liquid-rust@42055c3)) Features * Indexing by variable ([c216a439](cobalt-org/liquid-rust@c216a43), closes [cobalt-org#209](cobalt-org/liquid-rust#209)) * **for_block:** support parameters with variables ([7376ccf5](cobalt-org/liquid-rust@7376ccf), closes [cobalt-org#162](cobalt-org/liquid-rust#162)) * **filters:** * Added: "at_most" ([be3e55c0](cobalt-org/liquid-rust@be3e55c)) * Added: "at_least" ([be3e55c0](cobalt-org/liquid-rust@be3e55c)) * **tags:** * Added tablerow ([18660736](cobalt-org/liquid-rust@1866073), closes [cobalt-org#163](cobalt-org/liquid-rust#163)) * Added ifchanged ([18660736](cobalt-org/liquid-rust@1866073), closes [cobalt-org#163](cobalt-org/liquid-rust#163)) * Added increment ([18660736](cobalt-org/liquid-rust@1866073), closes [cobalt-org#163](cobalt-org/liquid-rust#163)) * Added decrement ([18660736](cobalt-org/liquid-rust@1866073), closes [cobalt-org#163](cobalt-org/liquid-rust#163)) Bug Fixes * **for_block:** make ranges inclusive. ([42055c35](cobalt-org/liquid-rust@42055c3))
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pretty much just stuck error-chain into
main(). The tests still pass (I guess you didn't really write a lot of tests for this) and the actual error handling is more central.I still feel like someone should go over the code and add some
chain_errs all over the place but that's up to you.I also did not really test the current output, it probably doesn't show a lot of useful information as long as there is no
chain_err.I also added a mechanism to declare dependencies (e.g. serve needs build) which then even further centralises error handling.
Please do me a favour and let someone thoroughly review those changes.