-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Semantic errors include line numbers where possible #247
Comments
From #303 |
To be clear, line numbers during render is more of #247 so I split this conversation off here so we can capture our thoughts. #303 is more focused on the fact that for I agree that we need to pass location information to tags/blocks. In all of this, we also need to keep #248 in mind. What value do you see in liquid error tracking line number vs just rendering the message with file/line? I've not really thought much on this. |
For instance, we would be able to do calculations with the value (which might be useful for #248). |
The goal of this is so that runtime includes of partials can set this and then any error (usually the `trace`) that happens within that partial can be prefixed with the name. Eventually we also want these to include line numbers (see cobalt-org#247). In the end, this will make the errors look more like what you'd expect from a compiler error.
Expanding on #232, we can capture the line associated with a block / filter / etc and report that during the render phase.
The text was updated successfully, but these errors were encountered: