Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revamp tag/block API #315

Closed
epage opened this issue Dec 27, 2018 · 1 comment · Fixed by #341
Closed

Revamp tag/block API #315

epage opened this issue Dec 27, 2018 · 1 comment · Fixed by #341
Labels
api-break enhancement Improve the expected

Comments

@epage
Copy link
Member

epage commented Dec 27, 2018 •
edited
Loading

Similar to #301 but without the need for macro writing.

Blocks should include an end<something> to avoid creating that when rendering.
@epage epage added enhancement Improve the expected api-break labels Dec 27, 2018
@epage epage mentioned this issue Jan 12, 2019
Open
@epage
Copy link
Member Author

epage commented Apr 7, 2019

For tags, we need

  • tag name
  • textual description
  • example of tag syntax

For blocks we need the above plus

  • end tag
  • description of what is in the block
  • The tag information repeated for each sub-block (think switch/match)

epage added a commit to epage/liquid-rust that referenced this issue May 7, 2019
@epage
feat: Reflection for tags/blocks
72f8cee 
Fixes cobalt-org#315

BREAKING CHANGE: Tag and Block APIs have changed, including name of
tag/block implementations.
@epage epage mentioned this issue May 7, 2019
Merged
1 task
@epage epage closed this as completed in #341 May 7, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
api-break enhancement Improve the expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Reflection for tags/blocks epage/liquid-rust
1 participant
@epage